-
Notifications
You must be signed in to change notification settings - Fork 151
Implement Deposit Requests #2748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anvacaru
wants to merge
16
commits into
master
Choose a base branch
from
eip-7685
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+642
−217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing Execution Layer Requests EIP-7685 and Deposit Requests EIP-6110.
Needs to be rebased to master after #2747 gets merged.KEVM Implementation for EIPs 7685/6110
Configuration & Structure Changes
Add
requests.md
file with execution layer request implementationAdd configuration cells:
<requestsRoot>
in block header<requests>
and<depositRequests>
in network sectionAdd execution flow logic:
#filterLogs
function to process transaction logs. After all transactions in a block have finished executing, rules for#filterLogs
will parse each log item to look for various requests (only Deposit implemented so far).#parseDepositRequest
: Validates and extracts deposit requests by filtering logs from the deposit contract with the correct event signature#extractDepositData
: Extracts the five deposit fields (pubkey, withdrawal_credentials, amount, signature, index) from raw log data according to EIP-6110 field offsets#isValidDepositEventData
: Validates deposit log structure by checking data length (576 bytes) and verifying all expected field offsets and sizes#computeRequestsHash
: Calculates the final 32-byte commitment hash that goes into the block header by processing all non-empty requests#computeRequestsHashIntermediate
: Builds the intermediate hash list by skipping empty requests, hashing valid requests, and concatenating results in request-type orderAdd protocol features:
Ghasrequests
flag (activated in Prague)EVMC_INVALID_BLOCK
status codeUpdate block hash calculations:
Update state management:
clearBLOCK
Updated K proof files